Re: [PATCH] Fix posix-cpu-timer breakage caused by stale p->last_ran value

On Thu, 2007-02-22 at 01:33 +0100, Thomas Gleixner wrote:
> Problem description at:
> http://bugzilla.kernel.org/show_bug.cgi?id=8048
> 
> Commit b18ec80396834497933d77b81ec0918519f4e2a7 
>     [PATCH] sched: improve migration accuracy
> optimized the scheduler time calculations, but broke posix-cpu-timers.
> 
> The problem is that the p->last_ran value is not updated after a context
> switch. So a subsequent call to current_sched_time() calculates with a
> stale p->last_ran value, i.e. accounts the full time, which the task was
> scheduled away.

Oops, missed that.  You could also remove the prev->last_ran assignment
just above your addition, and turn this into a negative cost bugfix :)

	-Mike

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] Fix posix-cpu-timer breakage caused by stale p->last_ran value
    • From: Thomas Gleixner <[email protected]>

• Prev by Date: Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux
• Next by Date: Re: [PATCH 03/29] mm: allow PF_MEMALLOC from softirq context
• Previous by thread: Re: [PATCH] Fix posix-cpu-timer breakage caused by stale p->last_ran value
• Next by thread: Modprobe as script breaks initramfs kernel?
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]