Re: [RFT] bridge: eliminate port_check workqueue

On 02/21, Stephen Hemminger wrote:
>
> This is what I was suggesting by getting rid of the work queue completely.

Can't comment this patch, but if we can get rid of the work_struct - good!

> -static void port_carrier_check(struct work_struct *work)
> +void br_port_carrier_check(struct net_bridge_port *p)
>  {
> -	struct net_bridge_port *p;
> -	struct net_device *dev;
> -	struct net_bridge *br;
> -
> -	dev = container_of(work, struct net_bridge_port,
> -			   carrier_check.work)->dev;
> -	work_release(work);

May I ask you to redo this patch on top of

	[PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR
	http://marc.theaimsgroup.com/?l=linux-kernel&m=117183517612775

?

We are removing the _NAR stuff, it would be nice to do this in a separate
patch.

Thanks!

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [RFT] bridge: eliminate port_check workqueue
    • From: Stephen Hemminger <[email protected]>

• References:
  • [PATCH] net/bridge/br_if.c: fix possible use-after-free in port_carrier_check()
    • From: Oleg Nesterov <[email protected]>
  • Re: [PATCH] net/bridge/br_if.c: fix possible use-after-free in port_carrier_check()
    • From: Stephen Hemminger <[email protected]>
  • Re: [PATCH] net/bridge/br_if.c: fix possible use-after-free in port_carrier_check()
    • From: Jarek Poplawski <[email protected]>
  • Re: [PATCH] net/bridge/br_if.c: fix possible use-after-free in port_carrier_check()
    • From: Oleg Nesterov <[email protected]>
  • [RFT] bridge: eliminate port_check workqueue
    • From: Stephen Hemminger <[email protected]>

• Prev by Date: Re: cat problem in tiny_tty driver (the source included)
• Next by Date: Re: [patch 00/21] 2.6.19-stable review
• Previous by thread: [RFT] bridge: eliminate port_check workqueue
• Next by thread: Re: [RFT] bridge: eliminate port_check workqueue
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]