Re: [PATCH] net/bridge/br_if.c: fix possible use-after-free in port_carrier_check()

On 02/21, Jarek Poplawski wrote:
>
> > On Wed, 21 Feb 2007 01:19:41 +0300
> > Oleg Nesterov <[email protected]> wrote:
> > 
> > > +	p = container_of(work, struct net_bridge_port, carrier_check.work);
> > >  
> > >  	rtnl_lock();
> > > -	p = dev->br_port;
> > > -	if (!p)
> > > -		goto done;
> > >  	br = p->br;
> 
> It doesn't matter very much but I think this would look
> better after the first if check.

OK. I can re-send if this patch is otherwise correct.

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • [RFT] bridge: eliminate port_check workqueue
    • From: Stephen Hemminger <[email protected]>

• References:
  • [PATCH] net/bridge/br_if.c: fix possible use-after-free in port_carrier_check()
    • From: Oleg Nesterov <[email protected]>
  • Re: [PATCH] net/bridge/br_if.c: fix possible use-after-free in port_carrier_check()
    • From: Stephen Hemminger <[email protected]>
  • Re: [PATCH] net/bridge/br_if.c: fix possible use-after-free in port_carrier_check()
    • From: Jarek Poplawski <[email protected]>

• Prev by Date: Re: [PATCH] EXPORT_SYMBOL() time functions
• Next by Date: [PATCH]: Remove __exit from mon_bin_exit & mon_text_exit.
• Previous by thread: Re: [PATCH] net/bridge/br_if.c: fix possible use-after-free in port_carrier_check()
• Next by thread: [RFT] bridge: eliminate port_check workqueue
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]