Re: PATCH? net/bridge/br_if.c: fix use after free in port_carrier_check()

On 02/20, David Howells wrote:
> 
> Oleg Nesterov <[email protected]> wrote:
> 
> >  static void release_nbp(struct kobject *kobj)
> >  {
> >  	struct net_bridge_port *p
> >  		= container_of(kobj, struct net_bridge_port, kobj);
> > +
> > +	dev_put(p->dev);
> 
> Does this need to be done with the mutex held?

I think no. At least the current code does dev_put() without mutex held.

>                                                     And does anything actually pay
> attention to the refcount on dev?  I assume not...

I guess net/core/dev.c:netdev_wait_allrefs(), but not sure.

> Should you clear p->dev->br_port before calling dev_put()?

Looks like it is protected by RCU... Anyway the current code does the same.

> Looks reasonable.  I like it.
> 
> Acked-By: David Howells <[email protected]>

Thanks! I'll re-send with a proper changelog later today.

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • PATCH? net/bridge/br_if.c: fix use after free in port_carrier_check()
    • From: Oleg Nesterov <[email protected]>
  • [PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR
    • From: Oleg Nesterov <[email protected]>
  • Re: [PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR
    • From: David Howells <[email protected]>
  • Re: [PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR
    • From: Oleg Nesterov <[email protected]>
  • Re: PATCH? net/bridge/br_if.c: fix use after free in port_carrier_check()
    • From: David Howells <[email protected]>

• Prev by Date: Re: [PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR
• Next by Date: Re: SATA problems
• Previous by thread: Re: PATCH? net/bridge/br_if.c: fix use after free in port_carrier_check()
• Next by thread: Re: [PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]