Re: PATCH? net/bridge/br_if.c: fix use after free in port_carrier_check()

Oleg Nesterov <[email protected]> wrote:

>  static void release_nbp(struct kobject *kobj)
>  {
>  	struct net_bridge_port *p
>  		= container_of(kobj, struct net_bridge_port, kobj);
> +
> +	dev_put(p->dev);

Does this need to be done with the mutex held?  And does anything actually pay
attention to the refcount on dev?  I assume not...

Should you clear p->dev->br_port before calling dev_put()?

Looks reasonable.  I like it.

Acked-By: David Howells <[email protected]>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: PATCH? net/bridge/br_if.c: fix use after free in port_carrier_check()
    • From: Oleg Nesterov <[email protected]>

• References:
  • PATCH? net/bridge/br_if.c: fix use after free in port_carrier_check()
    • From: Oleg Nesterov <[email protected]>
  • [PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR
    • From: Oleg Nesterov <[email protected]>
  • Re: [PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR
    • From: David Howells <[email protected]>
  • Re: [PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR
    • From: Oleg Nesterov <[email protected]>

• Prev by Date: linux-2.6.today: rtc_cmos init oops/panic in rtc_sysfs_remove_device()
• Next by Date: Re: GPL vs non-GPL device drivers
• Previous by thread: PATCH? net/bridge/br_if.c: fix use after free in port_carrier_check()
• Next by thread: Re: PATCH? net/bridge/br_if.c: fix use after free in port_carrier_check()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]