Re: [PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR

Oleg Nesterov <[email protected]> wrote:

> Afaics, noautorel work_struct buys nothing for "struct net_bridge_port".

You may be right.

> If del_nbp()->cancel_delayed_work(&p->carrier_check) fails, port_carrier_check
> may be called later anyway.

Called by what?  Something outside of br_if.c?

> So the reading of *work in port_carrier_check() is equally unsafe with or
> without this patch.

Hmmm... cancel_delayed_work() in del_nbp() probably ought to be followed by a
flush_scheduled_work().

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR
    • From: David Howells <[email protected]>
  • Re: [PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR
    • From: Oleg Nesterov <[email protected]>

• References:
  • [PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR
    • From: Oleg Nesterov <[email protected]>

• Prev by Date: Re: [ckrm-tech] [RFC][PATCH][2/4] Add RSS accounting and control
• Next by Date: Re: [PATCH 05/44 take 2] [UBI] internal common header
• Previous by thread: Re: [PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR
• Next by thread: Re: [PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]