On Jan 22 2007 10:41, Robert P. J. Day wrote:
>
>as opposed to the 100+ *other* definitions currently cluttering up the
>tree, which this patch would allow to be deleted *immediately*.
>
>forget it. i can see this argument is going nowhere and that, six
>months from now, some poor sucker is going to post, asking, "hey, you
>know all these TRUE/FALSE things? wouldn't it be great if we could,
>you know, clean those up? whaddya say?"
>
>and groundhog day will begin all over again ...
I don't get it why it's so hard to do (b) over (a)
(a) remove all TRUE/FALSE and add TRUE/FALSE to linux/types.h
as per http://lkml.org/lkml/2007/1/21/19
(b) see below
Signed-off-by: Jan Engelhardt <[email protected]>
Index: linux-2.6.20-rc5/drivers/net/wireless/strip.c
===================================================================
--- linux-2.6.20-rc5.orig/drivers/net/wireless/strip.c
+++ linux-2.6.20-rc5/drivers/net/wireless/strip.c
@@ -177,8 +177,6 @@ typedef struct {
MetricomNode node[NODE_TABLE_SIZE];
} MetricomNodeTable;
-enum { FALSE = 0, TRUE = 1 };
-
/*
* Holds the radio's firmware version.
*/
@@ -1209,7 +1207,7 @@ static void ResetRadio(struct strip *str
if (!strip_info->manual_dev_addr)
*(MetricomAddress *) strip_info->dev->dev_addr =
zero_address;
- strip_info->working = FALSE;
+ strip_info->working = false;
strip_info->firmware_level = NoStructure;
strip_info->next_command = CompatibilityCommand;
strip_info->watchdog_doprobe = jiffies + 10 * HZ;
@@ -1845,7 +1843,7 @@ static void RecvErr_Message(struct strip
}
#endif
if (!strip_info->working) {
- strip_info->working = TRUE;
+ strip_info->working = true;
printk(KERN_INFO "%s: Radio now in starmode\n",
strip_info->dev->name);
/*
@@ -2455,7 +2453,7 @@ static int strip_open_low(struct net_dev
strip_info->tx_left = 0;
strip_info->discard = 0;
- strip_info->working = FALSE;
+ strip_info->working = false;
strip_info->firmware_level = NoStructure;
strip_info->next_command = CompatibilityCommand;
strip_info->user_baud = get_baud(strip_info->tty);
#<EOF>
-`J'
--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
