Re: [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, etc.

On Sun, 30 Dec 2007, Ingo Molnar wrote:

> 
> * Julia Lawall <[email protected]> wrote:
> 
> > > your x86 patches (#7, #8 and #9) do not include any *_eq() 
> > > comparisons and they all seem to be correct. So picked those three 
> > > up into x86.git - let me know if there's any breakage in them that i 
> > > missed.
> > 
> > Only #7 is ok.  The other two have #include <jiffies.h> in the wrong 
> > place.  I will send new versions of #8 and #9 shortly.
> 
> hm, #include file order in a .c file should normally not matter - why 
> are they in the wrong place?

Because they are under #ifdefs, but the code that uses the time functions 
is not under the same #ifdef.

julia

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, etc.
  - From: Ingo Molnar <[email protected]>

References:
- [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, etc.
  - From: Julia Lawall <[email protected]>
- Re: [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, etc.
  - From: Andi Kleen <[email protected]>
- Re: [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, etc.
  - From: Julia Lawall <[email protected]>
- Re: [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, etc.
  - From: Ingo Molnar <[email protected]>
- Re: [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, etc.
  - From: Julia Lawall <[email protected]>
- Re: [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, etc.
  - From: Ingo Molnar <[email protected]>

Prev by Date: Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override
Next by Date: Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override
Previous by thread: Re: [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, etc.
Next by thread: Re: [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, etc.
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]