On Mon 2007-12-24 15:16:46, Julia Lawall wrote:
> From: Julia Lawall <[email protected]>
>
> The functions time_before, time_before_eq, time_after, and time_after_eq
> are more robust for comparing jiffies against other values.
>
> A simplified version of the semantic patch making this change is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
>
> // <smpl>
> @ change_compare_np @
> expression E;
> @@
>
> (
> - jiffies <= E
> + time_before_eq(jiffies,E)
> |
> - jiffies >= E
> + time_after_eq(jiffies,E)
> |
> - jiffies < E
> + time_before(jiffies,E)
> |
> - jiffies > E
> + time_after(jiffies,E)
> )
Maybe you should create new macro so that you don't have to pass the
jiffies all the time?
> if (!test_thread_flag (TIF_UAC_NOPRINT)) {
> - if (cnt >= 5 && jiffies - last_time > 5*HZ) {
> + if (cnt >= 5 && time_after(jiffies, last_time + 5*HZ)) {
&& time_after_now(last_time + 5*HZ)
or something?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
