Please ignore this patch, in which I have found an error.
julia
On Mon, 24 Dec 2007, Julia Lawall wrote:
> From: Julia Lawall <[email protected]>
>
> The functions time_before, time_before_eq, time_after, and time_after_eq
> are more robust for comparing jiffies against other values.
>
> A simplified version of the semantic patch making this change is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
>
> // <smpl>
> @ change_compare_np @
> expression E;
> @@
>
> (
> - jiffies <= E
> + time_before_eq(jiffies,E)
> |
> - jiffies >= E
> + time_after_eq(jiffies,E)
> |
> - jiffies < E
> + time_before(jiffies,E)
> |
> - jiffies > E
> + time_after(jiffies,E)
> )
>
> @ include depends on change_compare_np @
> @@
>
> #include <linux/jiffies.h>
>
> @ no_include depends on !include && change_compare_np @
> @@
>
> #include <linux/...>
> + #include <linux/jiffies.h>
> // </smpl>
>
> Signed-off-by: Julia Lawall <[email protected]>
> ---
>
> diff -r -u -p a/arch/alpha/kernel/traps.c b/arch/alpha/kernel/traps.c
> --- a/arch/alpha/kernel/traps.c 2007-10-22 11:24:57.000000000 +0200
> +++ b/arch/alpha/kernel/traps.c 2007-12-23 20:30:39.000000000 +0100
> @@ -16,6 +16,7 @@
> #include <linux/module.h>
> #include <linux/init.h>
> #include <linux/kallsyms.h>
> +#include <linux/jiffies.h>
>
> #include <asm/gentrap.h>
> #include <asm/uaccess.h>
> @@ -781,7 +782,7 @@ do_entUnaUser(void __user * va, unsigned
> with the unaliged access. */
>
> if (!test_thread_flag (TIF_UAC_NOPRINT)) {
> - if (cnt >= 5 && jiffies - last_time > 5*HZ) {
> + if (cnt >= 5 && time_after(jiffies, last_time + 5*HZ)) {
> cnt = 0;
> }
> if (++cnt < 5) {
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
