Re: [Jan Beulich] [PATCH] constify tables in kernel/sysctl_check.c

On Thu, Dec 20, 2007 at 04:14:05PM -0700, Eric W. Biederman wrote:

 > Remains the question whether it is intended that many, perhaps even
 > large, tables are compiled in without ever having a chance to get used,
 > i.e. whether there shouldn't #ifdef CONFIG_xxx get added.

 > -static struct trans_ctl_table trans_net_ax25_param_table[] = {
 > +static const struct trans_ctl_table trans_net_ax25_table[] = {

we lost the _param, which will cause a duplicate definition with ..
 
 > -static struct trans_ctl_table trans_net_ax25_table[] = {
 > +static const struct trans_ctl_table trans_net_ax25_table[] = {

cut-n-paste thinko ?

	Dave

-- 
http://www.codemonkey.org.uk
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [Jan Beulich] [PATCH] constify tables in kernel/sysctl_check.c
    • From: [email protected] (Eric W. Biederman)
  • Re: [Jan Beulich] [PATCH] constify tables in kernel/sysctl_check.c
    • From: "Jan Beulich" <[email protected]>

• References:
  • [Jan Beulich] [PATCH] constify tables in kernel/sysctl_check.c
    • From: [email protected] (Eric W. Biederman)

• Prev by Date: Re: [PATCH] misc: Removal of final callers using fastcall
• Next by Date: Re: Linux 2.6.24-rc6
• Previous by thread: [Jan Beulich] [PATCH] constify tables in kernel/sysctl_check.c
• Next by thread: Re: [Jan Beulich] [PATCH] constify tables in kernel/sysctl_check.c
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]