Re: Kernel bug: bluetooth meets TTY layer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 20 Dec 2007 21:17:10 +0100
Arjan van de Ven <[email protected]> wrote:

> David Newall wrote:
> > Hi Arjan,
> > 
> > I've not been able to find this file, "drivers/bluetooth/hci_tty.c", but 
> > anyway, This seems to be what happens: Hci_uart_close() flushes using 
> > hci_uart_flush().  Subsequently, in hci_dev_do_close(), (one step in 
> > hci_unregister_dev()), hci_uart_flush() is called again.  The comment in 
> > uart_flush_buffer(), relating to the WARN_ON(), indicates you can't 
> > flush after the port is closed; which sounds reasonable.  I think 
> > hci_uart_close() should set hdev->flush to NULL before returning.  
> > Hci_dev_do_close() does check for this.  The code path is rather 
> > involved and I'm not entirely clear of all steps, but I think that's 
> > what should be done.
> > 
> > Patch for stupidly obsolete kernel attached.
> 
> looks reasonable; unfortunately I don't know the tty code well enough to judge this patch...
> Alan?

I don't know the bluetooth code well enough to even guess and I've not
had time to study this one. 

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux