> I missed the context on this one. So this is checking for periods at > the end of messages for printk's. We would need something a little > cleverer to ensure we are only checking the contents of the string. But > eminently doable. > > /me plays > > Ok, yes this seems ok. Have added it for 0.13. Please remove it. The kernel printk messages are sentences. English language sentences end with a full stop. They are messages printed up for normal human beings to read and they should therefore be properly written. In fact you should warn if it ends with a newline without a full stop unless the next line is continuation of quoted text because that suggests a full stop has been missed out incorrectly. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: Trailing periods in kernel messages
- From: Frans Pop <[email protected]>
- Re: Trailing periods in kernel messages
- From: David Miller <[email protected]>
- Re: Trailing periods in kernel messages
- From: Joe Perches <[email protected]>
- Re: Trailing periods in kernel messages
- References:
- [PATCH 6/6] tick: add a missing dot in prink
- From: Li Zefan <[email protected]>
- Re: [PATCH 6/6] tick: add a missing dot in prink
- From: Frans Pop <[email protected]>
- Re: [PATCH 6/6] tick: add a missing dot in prink
- From: Li Zefan <[email protected]>
- Trailing periods in kernel messages (was: [PATCH 6/6] tick: add a missing dot in prink)
- From: Frans Pop <[email protected]>
- Re: Trailing periods in kernel messages (was: [PATCH 6/6] tick: add a missing dot in prink)
- From: Andrew Morton <[email protected]>
- Re: Trailing periods in kernel messages
- From: Li Zefan <[email protected]>
- Re: Trailing periods in kernel messages
- From: Joe Perches <[email protected]>
- Re: Trailing periods in kernel messages
- From: Li Zefan <[email protected]>
- Re: Trailing periods in kernel messages
- From: Joe Perches <[email protected]>
- Re: Trailing periods in kernel messages
- From: Andy Whitcroft <[email protected]>
- [PATCH 6/6] tick: add a missing dot in prink
- Prev by Date: Re: [PATCH] sky2: Use deferrable timer for watchdog
- Next by Date: Re: Kernel bug: bluetooth meets TTY layer
- Previous by thread: Re: Trailing periods in kernel messages
- Next by thread: Re: Trailing periods in kernel messages
- Index(es):