On Dec 20, 2007 12:05 PM, Kok, Auke <[email protected]> wrote: > > I can't even apply this patch and the e1000 one... not only is it whitespace > damaged it is also not properly formatted as patch at all. If you want me to take > these patches seriously, then please fix the formatting issues. Sigh - I use Pine, follow Documents/email-clients.txt for the recommended settings and obviously the pathces are not generated with whitespace damage at my end as I test those before sending out. So although I hate to see this happen there is nothing at this moment that I can do - except for attaching the patch instead of inlining it. Since they have already been reviewed inline, please see if the attached patches work for you. [parag@mini linux-2.6]$ scripts/checkpatch.pl --no-tree ../../Patches/e1000_main.c.patch total: 0 errors, 0 warnings, 8 lines checked Your patch has no obvious style problems and is ready for submission. [parag@mini linux-2.6]$ [parag@mini linux-2.6]$ vim drivers/net/e1000/e1000_main.c [parag@mini linux-2.6]$ patch -p1 < ../../Patches/e1000_main.c.patch patching file drivers/net/e1000/e1000_main.c [parag@mini linux-2.6]$ scripts/checkpatch.pl --no-tree ../../Patches/e1000e-netdev.c.patch total: 0 errors, 0 warnings, 8 lines checked Your patch has no obvious style problems and is ready for submission. [parag@mini linux-2.6]$ patch -p1 < ../../Patches/e1000e-netdev.c.patch patching file drivers/net/e1000e/netdev.c Thanks Parag
Attachment:
e1000_main.c.patch
Description: Binary data
Attachment:
e1000e-netdev.c.patch
Description: Binary data
- Follow-Ups:
- Re: [PATCH] e1000e: Use deferrable timer for watchdog
- From: "Kok, Auke" <[email protected]>
- Re: [PATCH] e1000e: Use deferrable timer for watchdog
- References:
- [PATCH] e1000e: Use deferrable timer for watchdog
- From: Parag Warudkar <[email protected]>
- Re: [PATCH] e1000e: Use deferrable timer for watchdog
- From: "Kok, Auke" <[email protected]>
- [PATCH] e1000e: Use deferrable timer for watchdog
- Prev by Date: Re: [Fwd: Re: [PATCH 4/5]PCI: x86 MMCONFIG: introduce pcibios_fix_bus_scan()]
- Next by Date: Re: [PATCH] Handle i_size > s_maxbytes correctly
- Previous by thread: Re: [PATCH] e1000e: Use deferrable timer for watchdog
- Next by thread: Re: [PATCH] e1000e: Use deferrable timer for watchdog
- Index(es):
 |