On Thu, Dec 20, 2007 at 09:19:00AM -0500, Tony Camuso wrote:
> Tony Camuso wrote:
>
>> Greg KH wrote:
>>> On Wed, Dec 19, 2007 at 05:17:51PM -0500, [email protected] wrote:
>>>> +extern struct pci_ops pci_legacy_ops; /* direct.c */
>>>
>>> This isn't needed in this patch at all, and might make the compiler
>>> confused if you were to build with only this patch present :(
>>>
>>> thanks,
>>>
>>> greg k-h
>> Yes, of course. I missed that. Thank you.
> I take that back.
>
> This struct must be declared extern because it is referenced in
> arch/x86/pci/common.c by pcibios_fix_bus_scan_quirk()
Sure, but you do not reference it in this patch, right? So it's not
needed until you actually use it, so just include it in the patch that
you are needing it in.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
