On 12/19/07, Kok, Auke <[email protected]> wrote:
[snip]
> I can't possibly see any benefit from this other than that you just add up to a
> whole second to the initialization cycle, which is bad.
>
Well, Ok but it can't be bad - I've been using this patch sometime and
haven't seen any problem at all and powertop shows it reduces the
wakeups-from-idle.
But whatever - no big deal since it already uses round_jiffies().
Parag
> >
> > Signed-off-by: Parag Warudkar <[email protected]>
> >
> > --- linux-2.6/drivers/net/e1000/e1000_main.c 2007-12-07
> > 10:04:39.000000000 -0500
> > +++ linux-2.6-work/drivers/net/e1000/e1000_main.c 2007-12-18
> > 20:38:38.000000000 -0500
> > @@ -1030,7 +1030,7 @@
> > adapter->tx_fifo_stall_timer.function = &e1000_82547_tx_fifo_stall;
> > adapter->tx_fifo_stall_timer.data = (unsigned long) adapter;
> >
> > - init_timer(&adapter->watchdog_timer);
> > + init_timer_deferrable(&adapter->watchdog_timer);
> > adapter->watchdog_timer.function = &e1000_watchdog;
> > adapter->watchdog_timer.data = (unsigned long) adapter;
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe netdev" in
> > the body of a message to [email protected]
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
