Masami Hiramatsu wrote:
>> These are:
>>
>> -add stack_addr() macro
>> -I prefer the table defintion macros in mine as it avoids the need to
>> cast the pointer passed to test_bit, but if you want them
>> to be u32 as in your patch, I can change it.
>
> please do so. we'd like to reduce ifdefs as less as possible:-)
>
>> -wrmsr/wrmsrl - use wrmsr() for both
>> -call is_IF_modifier with p->ainsn.insn in both
>> -check casting of jprobe_saved_sp, I get some compile warnings currently
>> with pointer comparisons to signed/unsigned types.
>
> Could you also add below?
> - fix some comments (it clarifies the meanings of the code)
> - add fix_riprel(). this useful to reduce ifdefs.
> - expand reenter_kprobe(). I think it treat above two blocks.
> - reassignment of regs->ip in kprobe_handler can be unified
> to "regs->ip = (unsigned long)addr;"
Oh, I forgot to point out important thing.
- please make bugfix patches first. I think my bugfix patches
need to go upstream before unification. It would cause some
crashes.
Thank you.
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division
e-mail: [email protected], [email protected]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
