Re: [PATCH 09/28] FS-Cache: Release page->private after failed readahead [try #2]

Nick Piggin <[email protected]> wrote:

> This is pretty nasty.

Why?  If the fs doesn't set PG_private or PG_fscache on any pages before
calling read_cache_pages(), there's no difference.

Furthermore, the differences only crop up in the error handling paths.

> I would suggest either to have the function return the number of pages that
> were added to pagecache,

Which helps how?

> or just open code it.

Well, I could give an alternative read_cache_pages(), I suppose, for just this
situation, but that means there are two parallel functions which then both
need to be maintained.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH 09/28] FS-Cache: Release page->private after failed readahead [try #2]
  - From: Nick Piggin <[email protected]>

References:
- Re: [PATCH 09/28] FS-Cache: Release page->private after failed readahead [try #2]
  - From: Nick Piggin <[email protected]>
- [PATCH 00/28] Permit filesystem local caching [try #2]
  - From: David Howells <[email protected]>
- [PATCH 09/28] FS-Cache: Release page->private after failed readahead [try #2]
  - From: David Howells <[email protected]>

Prev by Date: [PATCH] kthread: run kthreadd with max priority SCHED_FIFO
Next by Date: Re: sata_mv not working with a RocketRaid 2220
Previous by thread: Re: [PATCH 09/28] FS-Cache: Release page->private after failed readahead [try #2]
Next by thread: Re: [PATCH 09/28] FS-Cache: Release page->private after failed readahead [try #2]
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]