Re: [PATCH 5/4] x86: fix up asm-x86/pgtable*.h formatting

[Jeremy Fitzhardinge <jeremy@goop.org>]

Christoph Hellwig wrote:
> On Mon, Dec 10, 2007 at 12:55:33PM -0800, Jeremy Fitzhardinge wrote:
>   
>> +#define set_pte_atomic(pteptr, pteval)		set_pte(pteptr,pteval)
>> +#define set_pte_present(mm,addr,ptep,pteval)	set_pte_at(mm,addr,ptep,pteval)
>>  
>> +#define pte_clear(mm,addr,xp)				\
>> +	do {						\
>> +		set_pte_at(mm, addr, xp, __pte(0));	\
>> +	} while (0)
>> +
>>  #undef pmd_clear
>> +#define pmd_clear(xp)				\
>> +	do {					\
>> +		set_pmd(xp, __pmd(0));		\
>> +	} while (0)
>>     
>
> What about turning these into inline functions to get better type
> checking?
>   

I'll give it a go.  Some of these need to be macros because of #include
hell; I'm not sure if that applies to these ones.

    J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/