Re: [PATCH] x86_64: some whitespace cleanups in paging code

On Wed, Dec 05, 2007 at 05:37:24PM +0100, Heiko Carstens wrote:
> On Wed, Dec 05, 2007 at 03:40:12PM +0100, Joerg Roedel wrote:
> > This patch does some whitespace cleanups in the paging code to fix some
> > checkpatch.pl warnings of my formerly merged cleanup patches.
> >...
> > -			set_pmd(pmd + i,__pmd(addr | __PAGE_KERNEL_LARGE_EXEC));
> > +			set_pmd(pmd+i, __pmd(addr | __PAGE_KERNEL_LARGE_EXEC));
> 
> Did checkpatch enforce you to remove the spaces around '+'? I thought
> there was/is a common consensus that having spaces around operators is a good
> thing to have. IMHO it's much more readable...
> But anyway, it's not that I want to start a new thread about coding style :)

Checkpatch complained about a missing space after the comma. After I
added one it complained about a line longer than 80 characters. But
luckily it didn't complain about missing spaces around the plus sign ;)

-- 
           |           AMD Saxony Limited Liability Company & Co. KG
 Operating |         Wilschdorfer Landstr. 101, 01109 Dresden, Germany
 System    |                  Register Court Dresden: HRA 4896
 Research  |              General Partner authorized to represent:
 Center    |             AMD Saxony LLC (Wilmington, Delaware, US)
           | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • Re: [PATCH 1/3] x86_64: define all _PAGE_* in terms of _PAGE_BIT_*
    • From: Ingo Molnar <[email protected]>
  • [PATCH] x86_64: some whitespace cleanups in paging code
    • From: "Joerg Roedel" <[email protected]>
  • Re: [PATCH] x86_64: some whitespace cleanups in paging code
    • From: Heiko Carstens <[email protected]>

• Prev by Date: Re: [RFC PATCH 0/5] Union Mount: A Directory listing approach with lseek support
• Next by Date: [PATCH] fix group stop with exit race
• Previous by thread: Re: [PATCH] x86_64: some whitespace cleanups in paging code
• Next by thread: [PATCH 2/3] x86_64: use __PAGE_KERNEL* instead of _KERNPG_TABLE for 2MB PTEs in memory initialization
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]