Re: [PATCH] x86_64: some whitespace cleanups in paging code

On Wed, Dec 05, 2007 at 03:40:12PM +0100, Joerg Roedel wrote:
> This patch does some whitespace cleanups in the paging code to fix some
> checkpatch.pl warnings of my formerly merged cleanup patches.
>...
> -			set_pmd(pmd + i,__pmd(addr | __PAGE_KERNEL_LARGE_EXEC));
> +			set_pmd(pmd+i, __pmd(addr | __PAGE_KERNEL_LARGE_EXEC));

Did checkpatch enforce you to remove the spaces around '+'? I thought
there was/is a common consensus that having spaces around operators is a good
thing to have. IMHO it's much more readable...
But anyway, it's not that I want to start a new thread about coding style :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH] x86_64: some whitespace cleanups in paging code
  - From: "Joerg Roedel" <[email protected]>

References:
- Re: [PATCH 1/3] x86_64: define all _PAGE_* in terms of _PAGE_BIT_*
  - From: Ingo Molnar <[email protected]>
- [PATCH] x86_64: some whitespace cleanups in paging code
  - From: "Joerg Roedel" <[email protected]>

Prev by Date: Re: [PATCH] USB: option: Bind to the correct interface of the Huawei E220
Next by Date: Re: [patch 12/18] usb: mon nopage
Previous by thread: Re: [PATCH] x86_64: some whitespace cleanups in paging code
Next by thread: Re: [PATCH] x86_64: some whitespace cleanups in paging code
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]