Re: [PATCH] Declare PNP option parsing functions as __init

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 30-11-07 18:04, Thomas Renninger wrote:

If I have not overseen something, it should be rather obvious that those
can all be declared __init...
---------------

Declare PNP option parsing functions as __init

There are three kind of parse functions provided by PNP acpi/bios:
 - get current resources
 - set resources
 - get possible resources
The first two may be needed later at runtime.
The possible resource settings should never change dynamically.
And even if this would make any sense (I doubt it), the current implementation
only parses possible resource settings at early init time:
  -> declare all the option parsing __init

Signed-off-by: Thomas Renninger <[email protected]>

Yes. Obviousness aside,

(0) pnpacpi_add_device                          is only caller of
(1)   pnpacpi_parse_resource_option_data        is only caller of
(2)     pnpacpi_option_resource                 is only caller of
(3)       pnpacpi_parse_irq_option
(3)       pnpacpi_parse_dma_option
(3)       pnpacpi_parse_port_option
(3)       pnpacpi_parse_fixed_port_option
(3)       pnpacpi_parse_mem24_option
(3)       pnpacpi_parse_mem32_option
(3)       pnpacpi_parse_fixed_mem32_option
(3)       pnpacpi_parse_address_option
(3)       pnpacpi_parse_ext_irq_option

and

(0) build_devlist                               is only caller of
(1)   insert_device                             is only caller of
(2)     pnpbios_parse_data_stream               is only caller of
(3)       pnpbios_parse_resource_option_data    is only caller of
(4)         pnpbios_parse_mem_option
(4)         pnpbios_parse_mem32_option
(4)         pnpbios_parse_fixed_mem32_option
(4)         pnpbios_parse_irq_option
(4)         pnpbios_parse_dma_option
(4)         pnpbios_parse_port_option
(4)         pnpbios_parse_fixed_port_option

which given that both (0)s are __init already, means all are fine indeed.

Acked-By: Rene Herman <[email protected]>

Rene.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux