Re: [linux-usb-devel] USB deadlock after resume

[Laurent Pinchart <laurent.pinchart@skynet.be>]

On Wednesday 21 November 2007, Markus Rechberger wrote:
> On 11/21/07, Oliver Neukum <oliver@neukum.org> wrote:
> > Am Mittwoch 21 November 2007 schrieb Markus Rechberger:
> > > > Which URB is usb_kill_urb() called for?
> > >
> > > it's the usb_control_message which calls usb_kill_urb if I haven't got
> > > it wrong. (if you're looking for some other information please let me
> > > know)
> > > Although, I got a bit further with it. The error seems to happen
> > > earlier already.
> > > If I load the driver, and do not access the device after suspending
> > > all usb_control commands fail with -71 eproto.
> >
> > A timeout. You should add the RESET_RESUME quirk for your device.
> > usb_reset_device() from resume() is not a good idea.
>
> ok this is good to know, although I have to stick with kernel 2.6.21.3
> here. It's Laurent's driver best would be to check for the specific
> kernelversion and do whatever is appropriate.

I like the RESET_RESUME quirk best. Adding a new quirk to the uvcvideo driver 
doesn't really make sense when the USB subsystem is already able to handle 
this situation.

Best regards,

Laurent Pinchart
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/