Re: [PATCH]loop cleanup in fs/namespace.c - repost

> The patch given below replaces the goto-loop by a while-based one.

That certainly looks fine.  I would also replace the 'return' with
'break', but I guess that's more of a question of personal preference.

> Besides, it removes the export for the same routine, because there are
> no users for it outside of the core VFS code.

This doesn't look fine.  Did you test this?

mntput_no_expire() is called from mntput() which is an inline function
in mount.h.  So lots of callers of mntput() in modules will end up
trying to call mntput_no_expire() from modules.

$ nm fs/fuse/fuse.ko | grep mntput_no_expire
                 U mntput_no_expire

- z
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH]loop cleanup in fs/namespace.c - repost
    • From: Dmitri Vorobiev <[email protected]>

• References:
  • [PATCH]loop cleanup in fs/namespace.c - repost
    • From: Dmitri Vorobiev <[email protected]>

• Prev by Date: Re: Possibly SATA related freeze killed networking and RAID
• Next by Date: Re: + smack-version-11c-simplified-mandatory-access-control-kernel.patch added to -mm tree
• Previous by thread: [PATCH]loop cleanup in fs/namespace.c - repost
• Next by thread: Re: [PATCH]loop cleanup in fs/namespace.c - repost
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]