On Mon, 19 Nov 2007 00:32:51 +0100 Marcel Selhorst <[email protected]> wrote:
> Dear all,
>
> during the initialization of the TPM TIS driver, the necessary
> locality has to be requested earlier in the init-process. Depending on
> the used TPM chip, this leads to wrong information.
> For example: Lenovo X61s with Atmel TPM:
>
> tpm_tis 00:0a: 1.2 TPM (device-id 0xFFFF, rev-id 255)
>
> But correct is:
>
> tpm_tis 00:0c: 1.2 TPM (device-id 0x3203, rev-id 9)
>
> This short patch fixes this issue.
Is this bug sufficiently serious to warrant inclusion of the fix in
2.6.24? 2.6.23.x?
It looks like it's just a cosmetic thing, but I'd like to check...
> Signed-Off-by Marcel Selhorst <[email protected]>
Signed-off-by:, please.
> ---
> --- tpm_tis.c.orig 2007-11-19 00:21:09.000000000 +0100
> +++ tpm_tis.c 2007-11-19 00:21:23.000000000 +0100
`patch -p1' form, please. This should have been
--- a/drivers/char/tpm/tpm_tis.c
+++ a/drivers/char/tpm/tpm_tis.c
> @@ -450,6 +450,11 @@ static int tpm_tis_init(struct device *d
> goto out_err;
> }
>
> + if (request_locality(chip, 0) != 0) {
> + rc = -ENODEV;
> + goto out_err;
> + }
> +
Your email client is converting tabs to spaces.
http://mbligh.org/linuxdocs/Email/Clients/Thunderbird has help for this.
Thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
