Hello.
Andrew Morton wrote:
> I believe (args->nlen > CTL_MAXNAME) was correct.
I'll leave it to you.
But if you want to allow args->nlen == CTL_MAXNAME,
you also need to update do_sysctl().
int do_sysctl(int __user *name, int nlen, void __user *oldval, size_t __user *oldlenp,
void __user *newval, size_t newlen)
{
...
if (nlen <= 0 || nlen >= CTL_MAXNAME)
return -ENOTDIR;
...
}
Thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning.
- From: [email protected] (Eric W. Biederman)
- Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning.
- References:
- [PATCH] sysctl: Check length at deprecated_sysctl_warning.
- From: Tetsuo Handa <[email protected]>
- Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning.
- From: Andrew Morton <[email protected]>
- Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning.
- From: Tetsuo Handa <[email protected]>
- Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning.
- From: [email protected] (Eric W. Biederman)
- [PATCH] sysctl: Check length at deprecated_sysctl_warning.
- From: Tetsuo Handa <[email protected]>
- Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning.
- From: Andrew Morton <[email protected]>
- [PATCH] sysctl: Check length at deprecated_sysctl_warning.
- Prev by Date: Re: [PATCH] sysfs: fix off-by-one error in fill_read_buffer
- Next by Date: [PATCH] - drivers/kvm/* - remove ptr comparisons to 0
- Previous by thread: Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning.
- Next by thread: Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning.
- Index(es):
 |