Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning.

Hello.

Thanks for reformatting my patch
and sorry for surprising you with directory name
(I meant to type linux-2.6.24-rc2, not linux-2.6.22-rc2).

According to linux-2.6.23,
it seems that I should return -ENOTDIR
for invalid args->nlen value.

I got a question here regarding interpretation of CTL_MAXNAME .
Is args->nlen == CTL_MAXNAME valid?
It is treated as invalid while the definition says

  /* how many path components do we allow in a
     call to sysctl?   In other words, what is
     the largest acceptable value for the nlen
     member of a struct __sysctl_args to have? */

If "name[CTL_MAXNAME];" is what the author intended,
I think args->nlen == CTL_MAXNAME is valid.

Regards.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning.
    • From: [email protected] (Eric W. Biederman)

• References:
  • [PATCH] sysctl: Check length at deprecated_sysctl_warning.
    • From: Tetsuo Handa <[email protected]>
  • Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning.
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: [patch] audit support for SH
• Next by Date: MMC/SD: Write operation in invalid states by borken cards.
• Previous by thread: Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning.
• Next by thread: Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]