Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning.

Hello.

Eric W. Biederman wrote:
> name[CTL_MAXNAME} is not valid.
> name[0...CTL_MAXNAME-1] is valid.
Yes.

> The check that got lost in the refactoring was specfically:
> 
> -       if (tmp.nlen <= 0 || tmp.nlen >= CTL_MAXNAME)
> -               return -ENOTDIR;
Thus I think tmp.nlen == CTL_MAXNAME should be allowed
because tmp.nlen is used as "for (i = 0; i < tmp.nlen; i++)".
I think
	if (tmp.nlen <= 0 || tmp.nlen > CTL_MAXNAME)
		return -ENOTDIR;
is correct.

Thanks.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- [PATCH] sysctl: Check length at deprecated_sysctl_warning.
  - From: Tetsuo Handa <[email protected]>
- Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning.
  - From: Andrew Morton <[email protected]>
- Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning.
  - From: Tetsuo Handa <[email protected]>
- Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning.
  - From: [email protected] (Eric W. Biederman)

Prev by Date: Re: snd_hda_intel 2.6.24-rc2 bug: interrupts don't always work on Lenovo X60s
Next by Date: Re: [kvm-devel] [PATCH 3/8] KVM: PVDMA Guest: Guest-side routines for paravirtualized DMA
Previous by thread: Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning.
Next by thread: [PATCH] sysctl: Check length at deprecated_sysctl_warning.
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]