Re: [2.6 patch] x86 kprobes_64.c: make 3 functions static

[Arjan van de Ven <arjan@infradead.org>]

On Fri, 9 Nov 2007 07:03:26 +0100
Adrian Bunk <bunk@kernel.org> wrote:

> This patch makes the following needlessly global functions static:
> - kprobe_handler()
> - trampoline_probe_handler()
> - post_kprobe_handler()
> 


while I appreciate your cleanups, I would like to ask you to be a bit
careful with the x86/ ones; some of these are for now deliberate to
make unification between the 32 and 64 ones possible.. eg we're working
on getting the more cosmetic (and in this context, removing a static is
more or less cosmetic) changes away so that "diff" shows us the *real*
differences between the 32 and 64 bit versions... adding back in the
static is the opposite direction ;)

So.. if you find ones that are real for both 32 and 64 bit, by all
means, but otherwise be a bit careful..

Greetings,
   Arjan van de Ven
-- 
If you want to reach me at my work email, use arjan@linux.intel.com
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/