Re: [PATCH 1/2] NET: Re-add VLAN tag for devices incapable of keeping it

Krzysztof Halasa wrote:

Patrick McHardy <[email protected]> writes:

I think there is one more case that matters, which is briding
from a device with VLAN stripping for a VLAN not configured
locally. The tag will be stripped and will be lost for forwarded
packets.

I think we should drop such packets on RX. Anyway we shouldn't
forward them.

Bridging eth0 to eth1 should not pay attention to VLAN tags
at all (if the pkt comes in on VLAN 7, it should go out on VLAN 7),
in my opinion.  If the NIC is stripping the VLAN header, then this
cannot work unless something re-builds the VLAN header.  If the stripped
VLAN header is placed into the skb, then any code that does need to
rebuild it can do so.  It may be less efficient, but users can just
not use that NIC hardware for high-end solutions, and at any rate,
less efficient is better than broken.

Ben

--
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 1/2] NET: Re-add VLAN tag for devices incapable of keeping it
    • From: Krzysztof Halasa <[email protected]>

• References:
  • Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX device?
    • From: Rick Jones <[email protected]>
  • [PATCH 1/2] NET: Re-add VLAN tag for devices incapable of keeping it
    • From: "Dave Johnson" <[email protected]>
  • Re: [PATCH 1/2] NET: Re-add VLAN tag for devices incapable of keeping it
    • From: Patrick McHardy <[email protected]>
  • Re: [PATCH 1/2] NET: Re-add VLAN tag for devices incapable of keeping it
    • From: David Miller <[email protected]>
  • Re: [PATCH 1/2] NET: Re-add VLAN tag for devices incapable of keeping it
    • From: Patrick McHardy <[email protected]>
  • Re: [PATCH 1/2] NET: Re-add VLAN tag for devices incapable of keeping it
    • From: Krzysztof Halasa <[email protected]>

• Prev by Date: Re: writeout stalls in current -git
• Next by Date: RE: PATCH [2/8] scsi: megaraid_sas - add module param fast_load
• Previous by thread: Re: [PATCH 1/2] NET: Re-add VLAN tag for devices incapable of keeping it
• Next by thread: Re: [PATCH 1/2] NET: Re-add VLAN tag for devices incapable of keeping it
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]