Re: [PATCH 1/2] NET: Re-add VLAN tag for devices incapable of keeping it

From: Patrick McHardy <[email protected]>
Date: Mon, 05 Nov 2007 19:00:19 +0100

> This looks like a rather expensive operation for the unlikely case
> that packets will be received by a packet socket. IMO it should only
> be reconstructed if actually needed, by af_packet itself.

Completely agreed.  We should not do this by default when %99
of the networking stack simply does not care about this.

> As we discussed some time back storing the VLAN tag in the CB on
> TX clashes with other users of the CB like qdiscs, so we need a
> new field in the skb for this anyway.

Someone will have to find a way to remove some other fields in
sk_buff before I'm going to allow more space to be eaten up
by this completely fringe case feature.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 1/2] NET: Re-add VLAN tag for devices incapable of keeping it
    • From: Patrick McHardy <[email protected]>

• References:
  • Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX device?
    • From: Rick Jones <[email protected]>
  • [PATCH 1/2] NET: Re-add VLAN tag for devices incapable of keeping it
    • From: "Dave Johnson" <[email protected]>
  • Re: [PATCH 1/2] NET: Re-add VLAN tag for devices incapable of keeping it
    • From: Patrick McHardy <[email protected]>

• Prev by Date: Re: [to-be-posted-soon] Multiple handlers per marker
• Next by Date: Re: [git patches] Add and use media change notification
• Previous by thread: Re: [PATCH 1/2] NET: Re-add VLAN tag for devices incapable of keeping it
• Next by thread: Re: [PATCH 1/2] NET: Re-add VLAN tag for devices incapable of keeping it
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]