On 11/5/07, Marcel Holtmann <[email protected]> wrote: > Hi Dave, > > > In the rfcomm_tty_hangup the rfcomm_dev refcnt should be dropped later. > > > > If rfcomm_dev is destructed in tty_hangup function, then the later tty_close function will oops. > > your patch removes the complete release on hangup logic. That can't be > right. I think the problem is with calling tty_vhangup() and then > decrementing the reference count. In case we call tty_vhangup and we > have release on hangup we should not delete the device here. What about > the attached patch? Does it solve it? > How about this patch (attached), it works for me as well. Regards dave
Attachment:
diff.rfcomm.1
Description: Binary data
- References:
- [PATCH]bluetooth rfcomm_dev refcount bug fix
- From: Dave Young <[email protected]>
- Re: [PATCH]bluetooth rfcomm_dev refcount bug fix
- From: Marcel Holtmann <[email protected]>
- [PATCH]bluetooth rfcomm_dev refcount bug fix
- Prev by Date: RE: [PATCH 2/2] NET: Re-add VLAN tag for devices incapable of keeping it
- Next by Date: [git Patch] mm/util.c: Remove needless code
- Previous by thread: Re: [PATCH]bluetooth rfcomm_dev refcount bug fix
- Next by thread: [PATCH][another try]bluetooth rfcomm tty_close before destruct
- Index(es):
 |