Re: per-bdi-throttling: synchronous writepage doesn't work correctly

> > 
> >       See the file "Locking" for more details.
> > 
> > 
> > The "should set PG_Writeback" bit threw me off I guess.
> 
> Hmm, set_page_writeback() is also the one clearing the radix tree dirty
> tag. So if that is not called, we get in a bit of a mess, no?
> 
> Which makes me think hostfs is buggy.

Yes, looks like that sort of usage is not valid.  But not clearing the
dirty tag won't cause any malfunction, it'll just waste some CPU when
looking for dirty pages to write back.  This is probably why this
wasn't noticed earlier.

Miklos
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: per-bdi-throttling: synchronous writepage doesn't work correctly
    • From: Peter Zijlstra <[email protected]>

• References:
  • per-bdi-throttling: synchronous writepage doesn't work correctly
    • From: Miklos Szeredi <[email protected]>
  • Re: per-bdi-throttling: synchronous writepage doesn't work correctly
    • From: Peter Zijlstra <[email protected]>
  • Re: per-bdi-throttling: synchronous writepage doesn't work correctly
    • From: Miklos Szeredi <[email protected]>
  • Re: per-bdi-throttling: synchronous writepage doesn't work correctly
    • From: Peter Zijlstra <[email protected]>
  • Re: per-bdi-throttling: synchronous writepage doesn't work correctly
    • From: Peter Zijlstra <[email protected]>
  • Re: per-bdi-throttling: synchronous writepage doesn't work correctly
    • From: Peter Zijlstra <[email protected]>

• Prev by Date: Re: [PATCH] x86: show cpuinfo only for online CPUs
• Next by Date: Re: [PATCH] [sysfs]: make readlink result shorter when the symlink and its target shared some base sysfs subdirectory
• Previous by thread: Re: per-bdi-throttling: synchronous writepage doesn't work correctly
• Next by thread: Re: per-bdi-throttling: synchronous writepage doesn't work correctly
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]