On Thu, 2007-11-01 at 18:28 +0100, Miklos Szeredi wrote: > > The page not having PG_writeback set on return is a hint, but not fool > > proof, it could be the device is just blazing fast. > > Hmm, does it actually has to be foolproof though? What will happen if > bdi_writeout_inc() is called twice for the page? The device will get > twice the number of pages it deserves? That's not all that bad, > especially since that is a really really fast device. Basically, yes. But then again, that would require auditing all ->writepage() callsites.
Attachment:
signature.asc
Description: This is a digitally signed message part
- References:
- per-bdi-throttling: synchronous writepage doesn't work correctly
- From: Miklos Szeredi <[email protected]>
- Re: per-bdi-throttling: synchronous writepage doesn't work correctly
- From: Peter Zijlstra <[email protected]>
- Re: per-bdi-throttling: synchronous writepage doesn't work correctly
- From: Miklos Szeredi <[email protected]>
- Re: per-bdi-throttling: synchronous writepage doesn't work correctly
- From: Peter Zijlstra <[email protected]>
- Re: per-bdi-throttling: synchronous writepage doesn't work correctly
- From: Miklos Szeredi <[email protected]>
- per-bdi-throttling: synchronous writepage doesn't work correctly
- Prev by Date: Re: [PATCH] x86: show cpuinfo only for online CPUs
- Next by Date: Re: [PATCH 3/16] read/write_crX, clts and wbinvd for 64-bit paravirt
- Previous by thread: Re: per-bdi-throttling: synchronous writepage doesn't work correctly
- Next by thread: [PATCH] x86: show cpuinfo only for online CPUs
- Index(es):
 |