Re: [PATCH 2/2] Char: tty, add tty_schedule_wakeup

[Jiri Slaby <jirislaby@gmail.com>]

Paul Fulghum napsal(a):
> Jiri Slaby wrote:
>> + *    Functionally the same as tty_wakeup, but it can be used in hot
>> + *    paths. since the wakeup is scheduled and done in the future.
>>
> 
> I'm not familiar with the terminology 'hot paths',
> what do you mean by that?

Ah, thank you for the feedback, I should change this, since it seems to be
not so much descriptive.

Functionally the same as tty_wakeup, but it can be used in code, which is
expected to be fast and short (e.g. interrupt handler), since the wakeup is
scheduled and done in the future.

> Do you have an example of where you intend to
> use this new facility? The patch does not include
> such an example so it is difficult for me to see
> why you are adding this function.

I want to use it in all char drivers, which schedules a work only for
tty_wakeup() calling, because they don't want to include more code in
interrupt handlers for example (if I understand the code correctly, e.g.
n_tty discipline may invoke whole fasync machinery on tty_wakeup call).

If somebody thinks it's not needed (or it's overkill), the other approach
comes -- change all wakeup schedules with simple tty_wakeup().

thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/