Re: [PATCH] drivers/scsi/dpt_i2o: Convert to generic boolean

Matthew Wilcox wrote:

On Tue, Oct 30, 2007 at 11:54:22AM +0100, Richard Knutsson wrote:

Convert to use the generic boolean.
-	u8 initialized;
-	u8 in_use;		/* is the management node open*/
+	bool initialized:8;
+	bool in_use:8;		/* is the management node open*/

Are you serious?

Well, yes. It is since it was defined to really be 8 bits before, and there is no reason why a boolean would be 8 bits and not 1 or 16.

If it is overly cautious/not needed, then I don't mind removing the ':8'...

Richard Knutsson


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] drivers/scsi/dpt_i2o: Convert to generic boolean
    • From: Matthew Wilcox <[email protected]>

• References:
  • [PATCH] drivers/scsi/dpt_i2o: Convert to generic boolean
    • From: Richard Knutsson <[email protected]>
  • Re: [PATCH] drivers/scsi/dpt_i2o: Convert to generic boolean
    • From: Matthew Wilcox <[email protected]>

• Prev by Date: Re: [PATCH] Version 3 (2.6.23-rc8) Smack: Simplified Mandatory Access Control Kernel
• Next by Date: Re: [Linux-am33-list] [PATCH 0/2] MN10300: Add the MN10300 architecture to Linux kernel [try #2]
• Previous by thread: Re: [PATCH] drivers/scsi/dpt_i2o: Convert to generic boolean
• Next by thread: Re: [PATCH] drivers/scsi/dpt_i2o: Convert to generic boolean
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]