Re: [PATCH 0/4] Unexport several headers and cleanup

On Tue, 2007-10-30 at 15:50 +0200, Kirill A. Shutemov wrote:
> It's bad idea. Taken from directfb:
> 
> #if HAVE_ASM_PAGE_H
> #include <asm/page.h>
> #else
> #define PAGE_SIZE   sysconf( _SC_PAGESIZE )
> #endif
> 
> Other application can use something like this. I think we should drop
> empty headers.

Well, it ought to be using sysconf unconditionally, but I take your
point. I'm happy enough then -- and since it doesn't change the kernel
build it could perhaps even be considered for 2.6.24.

Here you are... make sure you use them in the correct order:
Reviewed-By: David Woodhouse <[email protected]>
Reviewed-By: David Woodhouse <[email protected]>
Reviewed-By: David Woodhouse <[email protected]>
Reviewed-By: David Woodhouse <[email protected]>

-- 
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 0/4] Unexport several headers and cleanup
    • From: "Kirill A. Shutemov" <[email protected]>
  • Re: [PATCH 0/4] Unexport several headers and cleanup
    • From: David Woodhouse <[email protected]>
  • Re: [PATCH 0/4] Unexport several headers and cleanup
    • From: "Kirill A. Shutemov" <[email protected]>

• Prev by Date: Re: [PATCH 1/2] [CRYPTO] tcrypt: Move sg_init_table out of timing loops
• Next by Date: 2.6.24-rc1: usb problem?
• Previous by thread: Re: [PATCH 0/4] Unexport several headers and cleanup
• Next by thread: [PATCH] drivers/scsi/lpfc/lpfc_hw.h: Some minor cleanup.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]