RE: [PATCH resend] Make the dev_*() family of macros in device.hcomplete

Hi Greg K-H,


> > +#define dev_info(dev, format, arg...)		\
> > +	dev_printk(KERN_INFO, dev, format, ## arg)
> > +
> >  #ifdef DEBUG
> >  #define dev_dbg(dev, format, arg...)		\
> > -	dev_printk(KERN_DEBUG , dev , format , ## arg)
> > +	dev_printk(KERN_DEBUG, dev, format, ## arg)
> 
> Those extra spaces are there for a good reason, older versions of gcc
> are broken without it.  So please, put them all back...

You mean I should add spaces before commas only where they were
initially or to all new code and/or macros? I've observed other kernel
code and more often there are no spaces before commas. I'm asking
because the CodingStyle document is not very explicit about this rule.


Thank you,
Emil.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH resend] Make the dev_*() family of macros in device.hcomplete
    • From: Greg KH <[email protected]>
  • Re: [PATCH resend] Make the dev_*() family of macros in device.hcomplete
    • From: Randy Dunlap <[email protected]>

• References:
  • [PATCH resend] Make the dev_*() family of macros in device.h complete
    • From: Emil Medve <[email protected]>
  • Re: [PATCH resend] Make the dev_*() family of macros in device.h complete
    • From: Greg KH <[email protected]>

• Prev by Date: Re: [PATCH] raise tsc clocksource rating
• Next by Date: Re: [PATCH] Only show RESOURCES_64BIT on relevant architectures
• Previous by thread: Re: [PATCH resend] Make the dev_*() family of macros in device.h complete
• Next by thread: Re: [PATCH resend] Make the dev_*() family of macros in device.hcomplete
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]