On Tue, 30 Oct 2007, Paul Jimenez wrote:
>
> Howdy! Here's a simple janitorish patch for you:
>
> This patch mainly hinges around two includes and their ramifications:
>
> #include <i8259.h> which provides cached_{slave,master}_mask
> #include <io_ports.h> which provides PIC_{MASTER,SLAVE}_{IMR,CMD}
>
> Adding these two includes and using those half dozen or so definitions
> removed 140+ lines of diffs between i8259_32.c and i8259_64.c, thus
> making it easier for the real substantitive differences between them to
> show up, and hopefully therefore making it easier to eventually merge
> the two.
Looks good. Can you please resend with a proper Signed-off-by ?
Run your patch through scripts/checkpatch.pl before sending it out :)
tglx
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
