Re: [2.6 patch] fs/afs/vlocation.c: fix off-by-one

Adrian Bunk <[email protected]> wrote:

> This patch fixes an off-by-one error spotted by the Coverity checker.

NAK.

Why do you assume it's a NUL-terminated string?  It's not.  It's a fixed
length character array that gets padded out with NULs.

Look 9 lines further down in the file from the change you made.  You'll notice
it is using memcmp() not strcmp().

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [2.6 patch] fs/afs/vlocation.c: fix off-by-one
    • From: David Howells <[email protected]>
  • Re: [2.6 patch] fs/afs/vlocation.c: fix off-by-one
    • From: Adrian Bunk <[email protected]>

• References:
  • [2.6 patch] fs/afs/vlocation.c: fix off-by-one
    • From: Adrian Bunk <[email protected]>

• Prev by Date: Re: [PATCH] INPUT: fix hidinput_connect ignoring retval from input_register_device
• Next by Date: Re: [PATCH] proc_fs.h redux
• Previous by thread: [2.6 patch] fs/afs/vlocation.c: fix off-by-one
• Next by thread: Re: [2.6 patch] fs/afs/vlocation.c: fix off-by-one
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]