Re: [PATCH] INPUT: fix hidinput_connect ignoring retval from input_register_device

On Mon, 29 Oct 2007, Dmitry Torokhov wrote:

> Please don't - the fix is completely broken for multi-input devices -
> if 2nd device fails to register we bail out of hidinput_connect and
> thus never set HID_CLAIMED_INPUT bit. So when we disconnect device we
> never call hidinput_disconnect and who knows what will happen after
> that.

You are of course right, stupid me. I won't commit anything before first 
morning coffee any more.

Thanks a lot.

-- 
Jiri Kosina
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- Re: [PATCH] INPUT: fix hidinput_connect ignoring retval from input_register_device
  - From: Dirk Hohndel <[email protected]>
- Re: [PATCH] INPUT: fix hidinput_connect ignoring retval from input_register_device
  - From: Jiri Kosina <[email protected]>
- Re: [PATCH] INPUT: fix hidinput_connect ignoring retval from input_register_device
  - From: "Dmitry Torokhov" <[email protected]>

Prev by Date: Re: [PATCH] INPUT: fix hidinput_connect ignoring retval from input_register_device
Next by Date: Re: [2.6 patch] fs/afs/vlocation.c: fix off-by-one
Previous by thread: Re: [PATCH] INPUT: fix hidinput_connect ignoring retval from input_register_device
Next by thread: Re: [PATCH] INPUT: fix hidinput_connect ignoring retval from input_register_device
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]