Re: [patch 08/10] SLUB: Optional fast path using cmpxchg_local

On Sun, 28 Oct 2007, Pekka J Enberg wrote:

> -	local_irq_restore(flags);
> +	object = do_slab_alloc(s, c, gfpflags, node, addr);
> +	if (unlikely(!object))
> +		goto out;

Undoing the optimization that one of the earlier patches added.

The #ifdef version is for me at least easier to read. The code there is a 
special unit that has to deal with the most performance critical piece of 
the slab allocator. And the #ifdef there clarifies that any changes have 
to be done to both branches.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [patch 00/10] SLUB: SMP regression tests on Dual Xeon E5345 (8p) and new performance patches
    • From: Christoph Lameter <[email protected]>
  • [patch 08/10] SLUB: Optional fast path using cmpxchg_local
    • From: Christoph Lameter <[email protected]>
  • Re: [patch 08/10] SLUB: Optional fast path using cmpxchg_local
    • From: Pekka J Enberg <[email protected]>

• Prev by Date: Re: [PATCH] slub: nr_slabs is an atomic_long_t
• Next by Date: Re: bluetooth: hci_sysfs work queue problem
• Previous by thread: Re: [patch 08/10] SLUB: Optional fast path using cmpxchg_local
• Next by thread: Re: [patch 08/10] SLUB: Optional fast path using cmpxchg_local
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]