Re: [PATCH] proc_fs.h redux

On Sat, 2007-10-27 at 23:47 +0400, Alexey Dobriyan wrote:
> Remove proc_fs.h from headers that doesn't really need it.

> --- a/arch/powerpc/kernel/process.c
> +++ b/arch/powerpc/kernel/process.c
> @@ -17,6 +17,7 @@
>  #include <linux/errno.h>
>  #include <linux/sched.h>
>  #include <linux/kernel.h>
> +#include <linux/fs.h>

Your code doesn't match your patch description.

You've got new includes of:

<linux/fs.h>
<linux/proc_fs.h>
<linux/err.h>
<linux/kref.h>

and forward declarations of

struct proc_dir_entry;
struct file_operations;

As a general rule, I think it better to use includes
than use naked forward declarations.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] proc_fs.h redux
    • From: Russell King <[email protected]>
  • Re: [PATCH] proc_fs.h redux
    • From: Sam Ravnborg <[email protected]>
  • Re: [PATCH] proc_fs.h redux
    • From: Alexey Dobriyan <[email protected]>

• References:
  • [PATCH] proc_fs.h redux
    • From: Alexey Dobriyan <[email protected]>

• Prev by Date: Re: [PATCH] select PARAVIRT when PARAVIRT_GUEST on
• Next by Date: Re: BUG: lock held when returning to user space
• Previous by thread: [PATCH] proc_fs.h redux
• Next by thread: Re: [PATCH] proc_fs.h redux
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]