On Wed, Oct 24, 2007 at 08:06:14PM -0700, H. Peter Anvin wrote:
> Mike Frysinger wrote:
>> On 10/24/07, Jie Zhang <[email protected]> wrote:
>>> On 10/25/07, Adrian Bunk <[email protected]> wrote:
>>>> "extern inline" will have different semantics with gcc 4.3.
>>>>
>>>> Signed-off-by: Adrian Bunk <[email protected]>
>>>>
>>>> --- a/include/asm-blackfin/string.h
>>>> +++ b/include/asm-blackfin/string.h
>>>> @@ -4,7 +4,7 @@
>>>> #ifdef __KERNEL__ /* only set these up for kernel code */
>>>>
>>>> #define __HAVE_ARCH_STRCPY
>>>> -extern inline char *strcpy(char *dest, const char *src)
>>>> +static inline char *strcpy(char *dest, const char *src)
>>>> {
>>>> char *xdest = dest;
>>>> char temp = 0;
>>> What if we compile it with gcc 4.1?
>> we'll have to either use the gcc attributes to force old inline
>> behavior or use the gcc flag to force it
>
> We should probably have an extern_inline define then, assuming this is a
> function that does exist in a linkable version already -- otherwise "static
> inline" is correct.
Since we #define inline to be __attribute__((always_inline))
"extern inline" with the old semantics would only behave differently
if someone took the address of one of these string functions.
Does this happen anywhere in the blackfin port?
> -hpa
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
