Re: [PATCH 09/10] Change table chaining layout

On Wed, 24 Oct 2007, Jens Axboe wrote:
> > 
> > As it no longer sets the page only, perhaps it's a good idea to rename
> > sg_set_page() to sg_set()?
> 
> sg_set_buf() also sets length and offset, sg_set_page() is just a mirror
> of that. So I'd prefer to keep the naming.

I agree. And it's not like you can get it wrong, since if you only give 
the "page" argument, the preprocessor will complain loudly.

I think "sg_set_x()" is now rather logical - we fill in the SG entry 
(entirely), and the only question is _how_ we do it (which is what "x" 
says - using a page, or a kernel buffer).

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • Re: [PATCH 09/10] Change table chaining layout
    • From: Alan Cox <[email protected]>
  • Re: [PATCH 09/10] Change table chaining layout
    • From: Linus Torvalds <[email protected]>
  • Re: [PATCH 09/10] Change table chaining layout
    • From: Boaz Harrosh <[email protected]>
  • Re: [PATCH 09/10] Change table chaining layout
    • From: Jens Axboe <[email protected]>
  • Re: [PATCH 09/10] Change table chaining layout
    • From: Boaz Harrosh <[email protected]>
  • Re: [PATCH 09/10] Change table chaining layout
    • From: Jens Axboe <[email protected]>
  • Re: [PATCH 09/10] Change table chaining layout
    • From: Boaz Harrosh <[email protected]>
  • Re: [PATCH 09/10] Change table chaining layout
    • From: Linus Torvalds <[email protected]>
  • Re: [PATCH 09/10] Change table chaining layout
    • From: Jens Axboe <[email protected]>
  • Re: [PATCH 09/10] Change table chaining layout
    • From: Geert Uytterhoeven <[email protected]>
  • Re: [PATCH 09/10] Change table chaining layout
    • From: Jens Axboe <[email protected]>

• Prev by Date: Re: [PATCH] watchdog: add Nano 7240 driver
• Next by Date: Re: [PATCH 1/4] stringbuf: A string buffer implementation
• Previous by thread: Re: [PATCH 09/10] Change table chaining layout
• Next by thread: Re: [PATCH 09/10] Change table chaining layout
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]