Re: [PATCH 09/10] Change table chaining layout

[Jens Axboe <jens.axboe@oracle.com>]

On Tue, Oct 23 2007, Boaz Harrosh wrote:
> On Mon, Oct 22 2007 at 23:47 +0200, Linus Torvalds <torvalds@linux-foundation.org> wrote:
> > 
> > On Mon, 22 Oct 2007, Alan Cox wrote:
> > 
> >> For structures, not array elements or stack objects. Does gcc now get
> >> aligned correct as an attribute on a stack object ?
> > 
> > I think m68k stack layout still guarantees 4-byte-alignment, no?
> > 
> >> Still doesn't answer the rather more important question - why not just
> >> stick a NULL on the end instead of all the nutty hacks ?
> > 
> > You still do need one bit for the discontiguous case, so it's not like you 
> > can avoid the hacks anyway (unless you just blow up the structure 
> > entirely) and make it a separate member). So once you have that 
> > bit+pointer, using a separate NULL entry isn't exactly prettier. 
> > 
> > Especially as we actally want to see the difference between 
> > "end-of-allocation" and "not yet filled in", so you shouldn't use NULL 
> > anyway, you should probably use something like "all-ones".
> > 
> > 			Linus
> > -
> 
> Every one is so hysterical about this sg-chaining problem. And massive
> patches produced, that when a simple none intrusive solution is proposed
> it is totally ignored because every one thinks, "I can not be that stupid".
> Well Einstein said: "Simplicity is the ultimate sophistication". So no one
> need to feel bad.

It's all about the end goal - having maintainable and resilient code.
And I think the sg code will be better once we get past the next day or
so, and it'll be more robust. That is what matters to me, not the
simplicity of the patch itself.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/