Ingo Molnar <[email protected]> writes: > > the 'fastcall removal' changes to paravirt.c were over-eager: they > removed fastcall annotations from functions that are (or might be) > implemented in assembly. So if someone changes the compiler model, > such as -pg which disables regparm, the kernel breaks in nasty ways. It would be probably better to just not disable -mregparms. I don't think the compiler forces this. And e.g. on x86-64 regparms & -pg work just fine, why should it not on i386? > so this patch adds back fastcall annotations. This serves as > documentation for assembly calling-convention dependencies as > well. You should rename it then to "asmcall" or something. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- References:
- Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.
- From: WANG Cong <[email protected]>
- Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.
- From: Sam Ravnborg <[email protected]>
- Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.
- From: WANG Cong <[email protected]>
- Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.
- From: Al Viro <[email protected]>
- Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.
- From: WANG Cong <[email protected]>
- Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.
- From: Al Viro <[email protected]>
- Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.
- From: Ingo Molnar <[email protected]>
- Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.
- From: Jeremy Fitzhardinge <[email protected]>
- Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.
- From: Ingo Molnar <[email protected]>
- Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.
- From: Jeremy Fitzhardinge <[email protected]>
- Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.
- From: Ingo Molnar <[email protected]>
- Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.
- Prev by Date: kernel NULL pointer dereference in blk_rq_map_sg with v2.6.23-6815-g0895e91
- Next by Date: Hard lockups on 2.6.22.4-SMP
- Previous by thread: Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.
- Next by thread: Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.
- Index(es):
 |