[PATCH 0/3] ide: Fix use of paired device

At least 2 drivers (siimage and cs5535) have a bug where they use
the construct:

	ide_drive_t *pair	= &hwif->drives[drive->dn ^ 1];

To access the other drive in a master/slave pair. This is bogus
because drive->dn is not the unit number, but the global drive
number, thus can be 2 & 3 for ide1, 4 & 5 for ide2 etc...

This causes the driver to access beyond the drive array into lalaland
for any other interface than ide0 and in some case, actually crash :-)

These 3 patches fix those by introducing a ide_get_paired_drive()
helper that does the right thing and then using it.

Please apply to 2.6.24 if no objection.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 0/3] ide: Fix use of paired device
    • From: Bartlomiej Zolnierkiewicz <[email protected]>
  • Re: [PATCH 0/3] ide: Fix use of paired device
    • From: Sergei Shtylyov <[email protected]>
  • [PATCH 3/3] ide: Fix cs5535 driver accessing beyond array boundary
    • From: Benjamin Herrenschmidt <[email protected]>
  • [PATCH 2/3] ide: Fix siimage driver accessing beyond array boundary
    • From: Benjamin Herrenschmidt <[email protected]>
  • [PATCH 1/3] ide: Add ide_get_paired_drive() helper
    • From: Benjamin Herrenschmidt <[email protected]>

• Prev by Date: RE: [PATCH 5/5] I/OAT: Add completion callback for async_tx interface use
• Next by Date: [PATCH 1/3] ide: Add ide_get_paired_drive() helper
• Previous by thread: [git pull] audit patches (first series)
• Next by thread: [PATCH 1/3] ide: Add ide_get_paired_drive() helper
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]