RE: [PATCH 5/5] I/OAT: Add completion callback for async_tx interface use

>From: David Miller [mailto:[email protected]] 
>
>From: Andrew Morton <[email protected]>
>Date: Wed, 17 Oct 2007 17:44:38 -0700
>
>> On Wed, 17 Oct 2007 17:14:39 -0700
>> Shannon Nelson <[email protected]> wrote:
>> 
>> > +	tx->callback = (void *)ioat_dma_test_callback;
>> 
>> and when I remove this cast I get
>> 
>> drivers/dma/ioat_dma.c: In function 'ioat_dma_self_test':
>> drivers/dma/ioat_dma.c:718: warning: assignment from 
>incompatible pointer type
>> 
>> because ioat_dma_test_callback isn't void-returning.  
>Something is wrong
>> here.  I assume that ioat_dma_test_callback() should just be
>> void-returning?
>
>In fact this might crash on systems that conditionally pop
>return values based upon whether the function is void or not.
>

Yep - thanks.  That's my misuse of Dan's dma_async_tx_callback typedef.

sln
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 1/5] I/OAT: cleanup pci issues
    • From: Shannon Nelson <[email protected]>
  • [PATCH 5/5] I/OAT: Add completion callback for async_tx interface use
    • From: Shannon Nelson <[email protected]>
  • Re: [PATCH 5/5] I/OAT: Add completion callback for async_tx interface use
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH 5/5] I/OAT: Add completion callback for async_tx interface use
    • From: David Miller <[email protected]>

• Prev by Date: Re: [PATCH 5/5] I/OAT: Add completion callback for async_tx interface use
• Next by Date: [PATCH 0/3] ide: Fix use of paired device
• Previous by thread: Re: [PATCH 5/5] I/OAT: Add completion callback for async_tx interface use
• Next by thread: [PATCH 1/5] I/OAT: cleanup pci issues
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]