Re: [patch] scsi: fix crash in gdth_timeout()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


* Linus Torvalds <[email protected]> wrote:

> On Mon, 15 Oct 2007, Ingo Molnar wrote:
> > 
> > A further problem is probably that the GDTH timer is not stopped by a
> > failed GDTH probe?
> Indeed. Maybe this is a better fix?
> That driver is pretty messy, and this should have been found ealier. 
> James? Boaz?

> @@ -5213,6 +5213,10 @@ static int __init gdth_init(void)
>  #endif /* CONFIG_PCI */
>  	TRACE2(("gdth_detect() %d controller detected\n", gdth_ctr_count));
> +
> +	if (list_empty(&gdth_instances))
> +		return -ENODEV;

indeed - with this patch instead of the one i did the CONFIG_SCSI_GDTH=y 
bzImage boots up fine too, and no crash:

 Calling initcall 0x80a417e0: gdth_init+0x0/0xb20()
 GDT-HA: Storage RAID Controller Driver. Version: 3.05
 GDT-HA: Found 0 PCI Storage RAID Controllers
 initcall 0x80a417e0: gdth_init+0x0/0xb20() returned -19.
 initcall 0x80a417e0 ran for 5 msecs: gdth_init+0x0/0xb20()

Tested-by: Ingo Molnar <[email protected]>

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at
Please read the FAQ at

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux